From b0dac73a8899d6ad5db3564202f566ddb963b446 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kai=20Blo=CC=88cker?= Date: Mon, 3 Mar 2014 03:33:09 +0100 Subject: fixed p a r e n t h e t i c a l bug --- screenplain/export/html.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/screenplain/export/html.py b/screenplain/export/html.py index fa02acd..b987d81 100644 --- a/screenplain/export/html.py +++ b/screenplain/export/html.py @@ -115,7 +115,7 @@ class Formatter(object): self.out.write(to_html(dialog.character)) for parenthetical, text in dialog.blocks: - classes = 'parenthetical' if parenthetical else None + classes = ['parenthetical'] if parenthetical else None with self._tag('p', classes=classes): self.out.write(to_html(text)) -- cgit v1.2.3 From 8b0e94fb16b45632dc1f57ffdf9e76768a8aa656 Mon Sep 17 00:00:00 2001 From: Martin Vilcans Date: Mon, 3 Mar 2014 15:17:45 +0100 Subject: Tests that would have caught the p a r e n t h e t i c a l bug Bug was caused by a regression in d0c5183b4773e9dfac7113b24b492e0826c36bac See fix in b0dac73a8899d6ad5db3564202f566ddb963b446 --- tests/files/parenthetical.fountain | 3 +++ tests/files/parenthetical.fountain.fdx | 14 ++++++++++++++ tests/files/parenthetical.fountain.html | 1 + 3 files changed, 18 insertions(+) create mode 100644 tests/files/parenthetical.fountain create mode 100644 tests/files/parenthetical.fountain.fdx create mode 100644 tests/files/parenthetical.fountain.html diff --git a/tests/files/parenthetical.fountain b/tests/files/parenthetical.fountain new file mode 100644 index 0000000..9072cf8 --- /dev/null +++ b/tests/files/parenthetical.fountain @@ -0,0 +1,3 @@ +JOHN DOE +(screaming) +Hello!!! \ No newline at end of file diff --git a/tests/files/parenthetical.fountain.fdx b/tests/files/parenthetical.fountain.fdx new file mode 100644 index 0000000..b9eaad0 --- /dev/null +++ b/tests/files/parenthetical.fountain.fdx @@ -0,0 +1,14 @@ + + + + +JOHN DOE + + +(screaming) + + +Hello!!! + + + diff --git a/tests/files/parenthetical.fountain.html b/tests/files/parenthetical.fountain.html new file mode 100644 index 0000000..d233d53 --- /dev/null +++ b/tests/files/parenthetical.fountain.html @@ -0,0 +1 @@ +

JOHN DOE

(screaming)

Hello!!!

-- cgit v1.2.3