summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMyriad-Dreamin <35292584+Myriad-Dreamin@users.noreply.github.com>2024-05-06 22:00:51 +0800
committerLaurenz <laurmaedje@gmail.com>2024-05-17 14:27:59 +0200
commit03e3f01d549a21f70f3fec2eecd252bbc3b613c3 (patch)
treece1de79300d5758d4125c790236d48d8a1482b89
parenta4522b0fe89f157408b8ade6c58172857f0194ad (diff)
Slice the before_window at char boundaries (#4028)
Co-authored-by: Laurenz <laurmaedje@gmail.com>
-rw-r--r--crates/typst-ide/src/complete.rs10
1 files changed, 9 insertions, 1 deletions
diff --git a/crates/typst-ide/src/complete.rs b/crates/typst-ide/src/complete.rs
index e87cf23e..24cd7475 100644
--- a/crates/typst-ide/src/complete.rs
+++ b/crates/typst-ide/src/complete.rs
@@ -1053,7 +1053,7 @@ impl<'a> CompletionContext<'a> {
/// A small window of context before the cursor.
fn before_window(&self, size: usize) -> &str {
- &self.before[self.cursor.saturating_sub(size)..]
+ Scanner::new(self.before).from(self.cursor.saturating_sub(size))
}
/// Add a prefix and suffix to all applications.
@@ -1433,4 +1433,12 @@ mod tests {
test("#i", 2, &["int", "if conditional"], &["foo"]);
test("#().", 4, &["insert", "remove", "len", "all"], &["foo"]);
}
+
+ #[test]
+ fn test_before_window_char_boundary() {
+ // Check that the `before_window` doesn't slice into invalid byte
+ // boundaries.
+ let s = "😀😀 #text(font: \"\")";
+ test(s, s.len() - 2, &[], &[]);
+ }
}