From 3c94e05cedcb308d83028bfb42e19b29c1201ac1 Mon Sep 17 00:00:00 2001
From: bluebear94 <uruwi@protonmail.com>
Date: Wed, 2 Aug 2023 18:24:25 -0400
Subject: Warn if layout doesn't stabilize (#1684)

---
 tests/ref/meta/state.png | Bin 53638 -> 47450 bytes
 tests/src/tests.rs       |  21 +++++++++++++++++----
 tests/typ/meta/state.typ |  10 ++++++++++
 3 files changed, 27 insertions(+), 4 deletions(-)

(limited to 'tests')

diff --git a/tests/ref/meta/state.png b/tests/ref/meta/state.png
index d179c3c5..9b3bf57c 100644
Binary files a/tests/ref/meta/state.png and b/tests/ref/meta/state.png differ
diff --git a/tests/src/tests.rs b/tests/src/tests.rs
index a8cf25f7..f7eceead 100644
--- a/tests/src/tests.rs
+++ b/tests/src/tests.rs
@@ -670,8 +670,14 @@ fn parse_part_metadata(source: &Source) -> TestPartMetadata {
         compare_ref = get_flag_metadata(line, "Ref").or(compare_ref);
         validate_hints = get_flag_metadata(line, "Hints").or(validate_hints);
 
-        fn num(s: &mut Scanner) -> usize {
-            s.eat_while(char::is_numeric).parse().unwrap()
+        fn num(s: &mut Scanner) -> isize {
+            let mut first = true;
+            let n = &s.eat_while(|c: char| {
+                let valid = first && c == '-' || c.is_numeric();
+                first = false;
+                valid
+            });
+            n.parse().unwrap_or_else(|e| panic!("{n} is not a number ({e})"))
         }
 
         let comments_until_code =
@@ -681,8 +687,15 @@ fn parse_part_metadata(source: &Source) -> TestPartMetadata {
             let first = num(s) - 1;
             let (delta, column) =
                 if s.eat_if(':') { (first, num(s) - 1) } else { (0, first) };
-            let line = (i + comments_until_code) + delta;
-            source.line_column_to_byte(line, column).unwrap()
+            let line = (i + comments_until_code)
+                .checked_add_signed(delta)
+                .expect("line number overflowed limits");
+            source
+                .line_column_to_byte(
+                    line,
+                    usize::try_from(column).expect("column number overflowed limits"),
+                )
+                .unwrap()
         };
 
         let error_factory: fn(Range<usize>, String) -> UserOutput = UserOutput::error;
diff --git a/tests/typ/meta/state.typ b/tests/typ/meta/state.typ
index 8f460ce1..1c329a95 100644
--- a/tests/typ/meta/state.typ
+++ b/tests/typ/meta/state.typ
@@ -46,3 +46,13 @@ Was: #locate(location => {
 #trait[Adventure]
 #trait[Fear]
 #trait[Anger]
+
+---
+// Make sure that a warning is produced if the layout fails to converge.
+// Warning: -3:1-6:1 layout did not converge within 5 attempts
+// Hint: -3:1-6:1 check if any states or queries are updating themselves
+#let s = state("x", 1)
+#locate(loc => {
+  s.update(s.final(loc) + 1)
+})
+#s.display()
-- 
cgit v1.2.3