summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDan Allen <dan.j.allen@gmail.com>2017-09-21 23:58:04 -0600
committerDan Allen <dan.j.allen@gmail.com>2017-09-22 00:07:44 -0600
commit129024b0d1ce1d4a6ed2087fb687429f017444a4 (patch)
treedb1a096b0f1195450888df5ed5f81b97c385eebd
parent863ece266d31c5cd99bd3c03a76c4a870deea521 (diff)
use assert_kind_of in place of assert ... is_a? in test suite
-rw-r--r--test/extensions_test.rb56
-rw-r--r--test/invoker_test.rb6
-rw-r--r--test/links_test.rb8
-rw-r--r--test/lists_test.rb2
-rw-r--r--test/options_test.rb2
-rw-r--r--test/reader_test.rb2
-rw-r--r--test/sections_test.rb2
7 files changed, 39 insertions, 39 deletions
diff --git a/test/extensions_test.rb b/test/extensions_test.rb
index e31ac1b7..0d7ea93b 100644
--- a/test/extensions_test.rb
+++ b/test/extensions_test.rb
@@ -247,7 +247,7 @@ context 'Extensions' do
Asciidoctor::Extensions.register :sample, SampleExtensionGroup.new
refute_nil Asciidoctor::Extensions.groups
assert_equal 1, Asciidoctor::Extensions.groups.size
- assert Asciidoctor::Extensions.groups[:sample].is_a? SampleExtensionGroup
+ assert_kind_of SampleExtensionGroup, Asciidoctor::Extensions.groups[:sample]
ensure
Asciidoctor::Extensions.unregister_all
end
@@ -259,7 +259,7 @@ context 'Extensions' do
end
refute_nil Asciidoctor::Extensions.groups
assert_equal 1, Asciidoctor::Extensions.groups.size
- assert Asciidoctor::Extensions.groups[:sample].is_a? Proc
+ assert_kind_of Proc, Asciidoctor::Extensions.groups[:sample]
ensure
Asciidoctor::Extensions.unregister_all
end
@@ -416,7 +416,7 @@ context 'Extensions' do
SampleExtensionGroup.register
doc = Asciidoctor::Document.new
assert doc.extensions?
- assert doc.extensions.is_a? Asciidoctor::Extensions::Registry
+ assert_kind_of Asciidoctor::Extensions::Registry, doc.extensions
ensure
Asciidoctor::Extensions.unregister_all
end
@@ -432,9 +432,9 @@ context 'Extensions' do
assert registry.preprocessors?
extensions = registry.preprocessors
assert_equal 1, extensions.size
- assert extensions.first.is_a? Asciidoctor::Extensions::ProcessorExtension
- assert extensions.first.instance.is_a? SamplePreprocessor
- assert extensions.first.process_method.is_a? ::Method
+ assert_kind_of Asciidoctor::Extensions::ProcessorExtension, extensions.first
+ assert_kind_of SamplePreprocessor, extensions.first.instance
+ assert_kind_of Method, extensions.first.process_method
end
test 'should instantiate include processors' do
@@ -444,9 +444,9 @@ context 'Extensions' do
assert registry.include_processors?
extensions = registry.include_processors
assert_equal 1, extensions.size
- assert extensions.first.is_a? Asciidoctor::Extensions::ProcessorExtension
- assert extensions.first.instance.is_a? SampleIncludeProcessor
- assert extensions.first.process_method.is_a? ::Method
+ assert_kind_of Asciidoctor::Extensions::ProcessorExtension, extensions.first
+ assert_kind_of SampleIncludeProcessor, extensions.first.instance
+ assert_kind_of Method, extensions.first.process_method
end
test 'should instantiate docinfo processors' do
@@ -457,9 +457,9 @@ context 'Extensions' do
assert registry.docinfo_processors?(:head)
extensions = registry.docinfo_processors
assert_equal 1, extensions.size
- assert extensions.first.is_a? Asciidoctor::Extensions::ProcessorExtension
- assert extensions.first.instance.is_a? SampleDocinfoProcessor
- assert extensions.first.process_method.is_a? ::Method
+ assert_kind_of Asciidoctor::Extensions::ProcessorExtension, extensions.first
+ assert_kind_of SampleDocinfoProcessor, extensions.first.instance
+ assert_kind_of Method, extensions.first.process_method
end
# NOTE intentionally using the legacy names
@@ -470,9 +470,9 @@ context 'Extensions' do
assert registry.treeprocessors?
extensions = registry.treeprocessors
assert_equal 1, extensions.size
- assert extensions.first.is_a? Asciidoctor::Extensions::ProcessorExtension
- assert extensions.first.instance.is_a? SampleTreeprocessor
- assert extensions.first.process_method.is_a? ::Method
+ assert_kind_of Asciidoctor::Extensions::ProcessorExtension, extensions.first
+ assert_kind_of SampleTreeprocessor, extensions.first.instance
+ assert_kind_of Method, extensions.first.process_method
end
test 'should instantiate postprocessors' do
@@ -482,9 +482,9 @@ context 'Extensions' do
assert registry.postprocessors?
extensions = registry.postprocessors
assert_equal 1, extensions.size
- assert extensions.first.is_a? Asciidoctor::Extensions::ProcessorExtension
- assert extensions.first.instance.is_a? SamplePostprocessor
- assert extensions.first.process_method.is_a? ::Method
+ assert_kind_of Asciidoctor::Extensions::ProcessorExtension, extensions.first
+ assert_kind_of SamplePostprocessor, extensions.first.instance
+ assert_kind_of Method, extensions.first.process_method
end
test 'should instantiate block processor' do
@@ -494,9 +494,9 @@ context 'Extensions' do
assert registry.blocks?
assert registry.registered_for_block? :sample, :paragraph
extension = registry.find_block_extension :sample
- assert extension.is_a? Asciidoctor::Extensions::ProcessorExtension
- assert extension.instance.is_a? SampleBlock
- assert extension.process_method.is_a? ::Method
+ assert_kind_of Asciidoctor::Extensions::ProcessorExtension, extension
+ assert_kind_of SampleBlock, extension.instance
+ assert_kind_of Method, extension.process_method
end
test 'should not match block processor for unsupported context' do
@@ -513,9 +513,9 @@ context 'Extensions' do
assert registry.block_macros?
assert registry.registered_for_block_macro? 'sample'
extension = registry.find_block_macro_extension 'sample'
- assert extension.is_a? Asciidoctor::Extensions::ProcessorExtension
- assert extension.instance.is_a? SampleBlockMacro
- assert extension.process_method.is_a? ::Method
+ assert_kind_of Asciidoctor::Extensions::ProcessorExtension, extension
+ assert_kind_of SampleBlockMacro, extension.instance
+ assert_kind_of Method, extension.process_method
end
test 'should instantiate inline macro processor' do
@@ -525,9 +525,9 @@ context 'Extensions' do
assert registry.inline_macros?
assert registry.registered_for_inline_macro? 'sample'
extension = registry.find_inline_macro_extension 'sample'
- assert extension.is_a? Asciidoctor::Extensions::ProcessorExtension
- assert extension.instance.is_a? SampleInlineMacro
- assert extension.process_method.is_a? ::Method
+ assert_kind_of Asciidoctor::Extensions::ProcessorExtension, extension
+ assert_kind_of SampleInlineMacro, extension.instance
+ assert_kind_of Method, extension.process_method
end
test 'should allow processors to be registered by a string name' do
@@ -537,7 +537,7 @@ context 'Extensions' do
assert registry.preprocessors?
extensions = registry.preprocessors
assert_equal 1, extensions.size
- assert extensions.first.is_a? Asciidoctor::Extensions::ProcessorExtension
+ assert_kind_of Asciidoctor::Extensions::ProcessorExtension, extensions.first
end
end
diff --git a/test/invoker_test.rb b/test/invoker_test.rb
index a1939121..fd559168 100644
--- a/test/invoker_test.rb
+++ b/test/invoker_test.rb
@@ -502,10 +502,10 @@ eve, islifeform - analyzes an image to determine if it's a picture of a life for
custom_backend_root = File.expand_path(File.join(File.dirname(__FILE__), 'fixtures', 'custom-backends'))
invoker = invoke_cli_to_buffer %W(-E haml -T #{custom_backend_root} -o -)
doc = invoker.document
- assert doc.converter.is_a? Asciidoctor::Converter::CompositeConverter
+ assert_kind_of Asciidoctor::Converter::CompositeConverter, doc.converter
selected = doc.converter.find_converter 'paragraph'
- assert selected.is_a? Asciidoctor::Converter::TemplateConverter
- assert selected.templates['paragraph'].is_a? Tilt::HamlTemplate
+ assert_kind_of Asciidoctor::Converter::TemplateConverter, selected
+ assert_kind_of Tilt::HamlTemplate, selected.templates['paragraph']
end
test 'should load custom templates from multiple template directories' do
diff --git a/test/links_test.rb b/test/links_test.rb
index d2c5916d..993b24bb 100644
--- a/test/links_test.rb
+++ b/test/links_test.rb
@@ -238,7 +238,7 @@ context 'Links' do
doc = document_from_string %(Here you can read about tigers.#{anchor})
output = doc.render
assert_equal '[tigers]', doc.catalog[:ids]['tigers']
- assert doc.catalog[:refs]['tigers'].is_a? Asciidoctor::Inline
+ assert_kind_of Asciidoctor::Inline, doc.catalog[:refs]['tigers']
assert_nil doc.catalog[:refs]['tigers'].text
assert_xpath '//a[@id = "tigers"]', output, 1
assert_xpath '//a[@id = "tigers"]/child::text()', output, 0
@@ -274,7 +274,7 @@ context 'Links' do
doc = document_from_string %(Here you can read about tigers.#{anchor})
output = doc.render
assert_equal 'Tigers', doc.catalog[:ids]['tigers']
- assert doc.catalog[:refs]['tigers'].is_a? Asciidoctor::Inline
+ assert_kind_of Asciidoctor::Inline, doc.catalog[:refs]['tigers']
assert_equal 'Tigers', doc.catalog[:refs]['tigers'].text
assert_xpath '//a[@id = "tigers"]', output, 1
assert_xpath '//a[@id = "tigers"]/child::text()', output, 0
@@ -291,7 +291,7 @@ context 'Links' do
%w([[tigers,{label-tigers}]] anchor:tigers[{label-tigers}]).each do |anchor|
doc = document_from_string %(Here you can read about tigers.#{anchor}), :attributes => { 'label-tigers' => 'Tigers' }
doc.render
- assert doc.catalog[:refs]['tigers'].is_a? Asciidoctor::Inline
+ assert_kind_of Asciidoctor::Inline, doc.catalog[:refs]['tigers']
assert_equal 'Tigers', doc.catalog[:refs]['tigers'].text
assert_equal 'Tigers', doc.catalog[:ids]['tigers']
end
@@ -301,7 +301,7 @@ context 'Links' do
%w([[tigers,<Tigers>]] anchor:tigers[<Tigers>]).each do |anchor|
doc = document_from_string %(Here you can read about tigers.#{anchor}), :backend => :docbook45
output = doc.convert :header_footer => false
- assert doc.catalog[:refs]['tigers'].is_a? Asciidoctor::Inline
+ assert_kind_of Asciidoctor::Inline, doc.catalog[:refs]['tigers']
assert_equal '<Tigers>', doc.catalog[:refs]['tigers'].text
assert_equal '<Tigers>', doc.references[:ids]['tigers']
assert_includes output, '<anchor id="tigers" xreflabel="&lt;Tigers&gt;"/>'
diff --git a/test/lists_test.rb b/test/lists_test.rb
index 47192efe..93db7ff2 100644
--- a/test/lists_test.rb
+++ b/test/lists_test.rb
@@ -4417,7 +4417,7 @@ context 'Lists model' do
doc = document_from_string input
list = doc.blocks.first
- assert list.is_a? Asciidoctor::List
+ assert_kind_of Asciidoctor::List, list
items = list.items
assert_equal 3, items.size
assert_equal list.items, list.content
diff --git a/test/options_test.rb b/test/options_test.rb
index c39fe090..5a28f40a 100644
--- a/test/options_test.rb
+++ b/test/options_test.rb
@@ -58,7 +58,7 @@ context 'Options' do
test 'should emit warning when unparsed options remain' do
redirect_streams do |stdout, stderr|
options = Asciidoctor::Cli::Options.parse!(%w(-b docbook - -))
- assert options.is_a? Hash
+ assert_kind_of Hash, options
assert_match(/asciidoctor: WARNING: extra arguments .*/, stderr.string.chomp)
end
end
diff --git a/test/reader_test.rb b/test/reader_test.rb
index 127a8561..4b5aec10 100644
--- a/test/reader_test.rb
+++ b/test/reader_test.rb
@@ -374,7 +374,7 @@ This is a paragraph outside the block.
context 'Type hierarchy' do
test 'PreprocessorReader should extend from Reader' do
reader = empty_document.reader
- assert reader.is_a?(Asciidoctor::Reader)
+ assert_kind_of Asciidoctor::PreprocessorReader, reader
end
test 'PreprocessorReader should invoke or emulate Reader initializer' do
diff --git a/test/sections_test.rb b/test/sections_test.rb
index 3ecfe325..0d67b315 100644
--- a/test/sections_test.rb
+++ b/test/sections_test.rb
@@ -674,7 +674,7 @@ not in section
doc = document_from_string input
heading = doc.blocks.first
- assert heading.is_a?(Asciidoctor::Block)
+ assert_kind_of Asciidoctor::Block, heading
assert_equal :floating_title, heading.context
assert_equal '_independent_heading', heading.id
assert doc.catalog[:ids].has_key?('_independent_heading')