Put id attributes on TOC entries #7907 (#7913)

Naming scheme of id is "toc-" + id of linked to header/section.
In Shared, will effect HTML, Markdown, Powerpoint, and RTF.

3 files changed, 50 insertions, 9 deletions

diff --git a/test/Tests/Helpers.hs b/test/Tests/Helpers.hs
index 24db9c500..697d84dbf 100644
--- a/test/Tests/Helpers.hs
+++ b/test/Tests/Helpers.hs
@@ -36,6 +36,7 @@ import Test.Tasty
 import Test.Tasty.Golden.Advanced (goldenTest)
 import Test.Tasty.HUnit
 import Text.Pandoc.Builder (Blocks, Inlines, doc, plain)
+import qualified Text.Pandoc.Builder as B
 import Text.Pandoc.Class
 import Text.Pandoc.Definition
 import Text.Pandoc.Options
@@ -150,6 +151,12 @@ instance ToString Pandoc where
 instance ToString Blocks where
   toString = unpack . purely (writeNative def) . toPandoc
 
+instance ToString [Block] where
+  toString = toString . B.fromList
+
+instance ToString Block where
+  toString = toString . B.singleton 
+
 instance ToString Inlines where
   toString = unpack . trimr . purely (writeNative def) . toPandoc
 
diff --git a/test/Tests/Shared.hs b/test/Tests/Shared.hs
index 19e55e791..797d9fe75 100644
--- a/test/Tests/Shared.hs
+++ b/test/Tests/Shared.hs
@@ -14,11 +14,14 @@ module Tests.Shared (tests) where
 
 import System.FilePath.Posix (joinPath)
 import Test.Tasty
-import Test.Tasty.HUnit (assertBool, testCase, (@?=))
 import Text.Pandoc.Arbitrary ()
 import Text.Pandoc.Builder
 import Text.Pandoc.Shared
-import Text.Pandoc.Writers.Shared (toLegacyTable)
+import Test.Tasty.HUnit
+import Tests.Helpers
+import Text.Pandoc
+import Text.Pandoc.Writers.Shared
+import qualified Data.Text as T
 
 tests :: [TestTree]
 tests = [ testGroup "compactifyDL"
@@ -29,7 +32,38 @@ tests = [ testGroup "compactifyDL"
           ]
         , testGroup "collapseFilePath" testCollapse
         , testGroup "toLegacyTable" testLegacyTable
-        ]
+        , testGroup "table of contents" testTOC
+        ] 
+
+givesTOC :: String -> (Blocks, Blocks) -> TestTree
+givesTOC desc (blocks, toc) = test (toTableOfContents def) desc (toList blocks, head . toList $ toc)
+
+linkId :: T.Text -> T.Text -> T.Text -> Inlines -> Inlines
+linkId lId = linkWith (lId,[],[])
+
+headerId :: T.Text -> Int -> Inlines -> Blocks
+headerId hId = headerWith (hId,[],[])
+
+testTOC :: [TestTree]
+testTOC = [ givesTOC "empty case" $ mempty =?> bulletList []
+          , givesTOC "no headers" $ horizontalRule =?> bulletList []
+          , givesTOC "unlinked header" $
+              header 1 "H1" =?>
+              bulletList [plain "H1"]
+          , givesTOC "linked header" $
+              headerId "h1" 1 "H1" =?>
+              bulletList [plain $ linkId "toc-h1" "#h1" "" "H1"]
+          , givesTOC "nested headlines" $
+              header 1 "H1a" <> header 2 "H2" =?>
+              bulletList [plain "H1a" <> bulletList [plain "H2"]]
+          , givesTOC "only referenced headers" $
+              header 1 "H1a" <> headerId "h2" 2 "H2" =?>
+              bulletList [plain "H1a" <> 
+                          bulletList [plain $ linkId "toc-h2" "#h2" "" "H2"]]
+          , givesTOC "section id used as backup" $
+              divWith ("sec",["section"],[]) (header 1 "H1") =?>
+              bulletList [plain $ linkId "toc-sec" "#sec" "" "H1"]             
+          ]
 
 testCollapse :: [TestTree]
 testCollapse = map (testCase "collapse")
diff --git a/test/command/toc.md b/test/command/toc.md
index 543f97ba9..7474955e5 100644
--- a/test/command/toc.md
+++ b/test/command/toc.md
@@ -16,12 +16,12 @@
 ## e
 :::
 ^D
--   [A](#a)
-    -   [b](#b)
--   [B](#b-1)
-    -   [b](#b-2)
--   [E](#e)
-    -   [e](#e-1)
+-   [A](#a){#toc-a}
+    -   [b](#b){#toc-b}
+-   [B](#b-1){#toc-b-1}
+    -   [b](#b-2){#toc-b-2}
+-   [E](#e){#toc-e}
+    -   [e](#e-1){#toc-e-1}
 
 # A