summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorLaurenz <laurmaedje@gmail.com>2022-10-31 15:47:49 +0100
committerLaurenz <laurmaedje@gmail.com>2022-10-31 15:47:49 +0100
commitf547c97072881069417acd3b79b08fb7ecf40ba2 (patch)
tree9d860b14be6bb4fae746e48f3dbdab00b28f6625 /src
parent671ce3dedd40067bb5cea84fe0739de013827053 (diff)
Reduce usage of `finalize`
Diffstat (limited to 'src')
-rw-r--r--src/library/math/mod.rs15
-rw-r--r--src/library/text/link.rs26
-rw-r--r--src/library/text/raw.rs10
-rw-r--r--src/model/show.rs1
-rw-r--r--src/model/vm.rs4
5 files changed, 28 insertions, 28 deletions
diff --git a/src/library/math/mod.rs b/src/library/math/mod.rs
index b23ed7cf..63d5f419 100644
--- a/src/library/math/mod.rs
+++ b/src/library/math/mod.rs
@@ -103,16 +103,13 @@ impl Show for MathNode {
&self,
_: Tracked<dyn World>,
styles: StyleChain,
- mut realized: Content,
+ realized: Content,
) -> SourceResult<Content> {
- let mut map = StyleMap::new();
- map.set_family(styles.get(Self::FAMILY).clone(), styles);
-
- if self.display() {
- realized = realized.spaced(styles.get(Self::ABOVE), styles.get(Self::BELOW));
- }
-
- Ok(realized.styled_with_map(map))
+ Ok(if self.display() {
+ realized.spaced(styles.get(Self::ABOVE), styles.get(Self::BELOW))
+ } else {
+ realized
+ })
}
}
diff --git a/src/library/text/link.rs b/src/library/text/link.rs
index 98a867a8..11d55956 100644
--- a/src/library/text/link.rs
+++ b/src/library/text/link.rs
@@ -73,17 +73,21 @@ impl Show for LinkNode {
}
fn realize(&self, _: Tracked<dyn World>, _: StyleChain) -> SourceResult<Content> {
- Ok(self.body.clone().unwrap_or_else(|| match &self.dest {
- Destination::Url(url) => {
- let mut text = url.as_str();
- for prefix in ["mailto:", "tel:"] {
- text = text.trim_start_matches(prefix);
+ Ok(self
+ .body
+ .clone()
+ .unwrap_or_else(|| match &self.dest {
+ Destination::Url(url) => {
+ let mut text = url.as_str();
+ for prefix in ["mailto:", "tel:"] {
+ text = text.trim_start_matches(prefix);
+ }
+ let shorter = text.len() < url.len();
+ Content::Text(if shorter { text.into() } else { url.clone() })
}
- let shorter = text.len() < url.len();
- Content::Text(if shorter { text.into() } else { url.clone() })
- }
- Destination::Internal(_) => Content::Empty,
- }))
+ Destination::Internal(_) => Content::Empty,
+ })
+ .styled(TextNode::LINK, Some(self.dest.clone())))
}
fn finalize(
@@ -93,8 +97,6 @@ impl Show for LinkNode {
mut realized: Content,
) -> SourceResult<Content> {
let mut map = StyleMap::new();
- map.set(TextNode::LINK, Some(self.dest.clone()));
-
if let Smart::Custom(fill) = styles.get(Self::FILL) {
map.set(TextNode::FILL, fill);
}
diff --git a/src/library/text/raw.rs b/src/library/text/raw.rs
index 6d19deff..85e8133c 100644
--- a/src/library/text/raw.rs
+++ b/src/library/text/raw.rs
@@ -105,7 +105,12 @@ impl Show for RawNode {
realized = Content::block(realized);
}
- Ok(realized)
+ let mut map = StyleMap::new();
+ map.set(TextNode::OVERHANG, false);
+ map.set(TextNode::HYPHENATE, Smart::Custom(Hyphenate(false)));
+ map.set(TextNode::SMART_QUOTES, false);
+
+ Ok(realized.styled_with_map(map))
}
fn finalize(
@@ -116,9 +121,6 @@ impl Show for RawNode {
) -> SourceResult<Content> {
let mut map = StyleMap::new();
map.set_family(styles.get(Self::FAMILY).clone(), styles);
- map.set(TextNode::OVERHANG, false);
- map.set(TextNode::HYPHENATE, Smart::Custom(Hyphenate(false)));
- map.set(TextNode::SMART_QUOTES, false);
if self.block {
realized = realized.spaced(styles.get(Self::ABOVE), styles.get(Self::BELOW));
diff --git a/src/model/show.rs b/src/model/show.rs
index 86659463..cc84e6db 100644
--- a/src/model/show.rs
+++ b/src/model/show.rs
@@ -28,7 +28,6 @@ pub trait Show: 'static {
/// this for effects that should work even in the face of a user-defined
/// show rule, for example:
/// - Application of general settable properties
- /// - Attaching things like semantics to a heading
///
/// Defaults to just the realized content.
#[allow(unused_variables)]
diff --git a/src/model/vm.rs b/src/model/vm.rs
index 614e2a9f..6207ffd5 100644
--- a/src/model/vm.rs
+++ b/src/model/vm.rs
@@ -12,7 +12,7 @@ use crate::{LangItems, World};
pub struct Vm<'a> {
/// The core context.
pub world: Tracked<'a, dyn World>,
- /// The route of source ids the machine took to reach its current location.
+ /// The route of source ids the VM took to reach its current location.
pub route: Tracked<'a, Route>,
/// The current location.
pub location: Option<SourceId>,
@@ -52,7 +52,7 @@ impl<'a> Vm<'a> {
}
}
- return Err("cannot access file system from here".into());
+ Err("cannot access file system from here".into())
}
/// The language items.